I was tracking the dpdk project, and focused on the branch that Daniel told me to work on.
So would the correct process be to push the patch to the spdk/dpdk gerrithub and discuss the commit, or the other way around?
Sure, I understand that. SPDK maintains a fork of dpdk in github at https://github.com/spdk/dpdk for the purpose of temporarily putting things in that we need that can’t make it upstream yet for whatever reason – this is the submodule in the SPDK repo. I’m not saying that it makes sense for your patch to land there permanently but it does make sense to talk about it.
No problem on not being on the call, we’ll get some input from the maintainers and others I’m sure…
The problem is that the patch is in dpdk and not in spdk, and this is the reason I offered to support it.
The patch (bellow) is only a few lines long modifying the deprecated attribute definition, a modification to the config, and an extra compilation flag.
All of the above are required in order to build dpdk 18.01 on CentOS6, there are no problems building spdk on CentOS6.
I understood that you are already applying minor patches to dpdk, so question is, whether this patch can be added?
Unfortunately due to some personal issues, I am unable to participate in today's meeting.
From: SPDK <email@example.com> on behalf of Luse, Paul E
Sent: Tuesday, May 8, 2018 4:25:29 PM
To: Storage Performance Development Kit
Subject: Re: [SPDK] Building spdk on CentOS6
Couple of quick things:
* thanks for putting all this time and effort into trying to make this work!
* in the community model, patches aren’t accepted based on one individual’s ability/desire to support them so appreciate the offer but in general any patch that is accepted becomes the responsibly of the community (mostly the maintainers) to support it long term. Otherwise we’d have what I like to call “the flea market model” where there’s a bunch of separate individuals supporting their own things with very little cohesiveness across everything J
So, wrt next steps, if the patch isn’t a tremendous amount of effort I would suggest you go ahead and submit it. That’s the best way to get everyone on the same page wrt exactly what we’re talking about. If it is some significant effort then, as Pawel states, you can call into a community meeting (see email I sent out last night) or you can explain more details on this list.
I think someone will answer you on this mailing list but there is community meeting today too. You can raise this if you wish.