As agreed during the SPDK Meetup early this month, Girish and I have rebased and updated the Histogram Utility changes and published a new pull request.

 

https://review.gerrithub.io/#/c/389053/

 

Thanks to Paul Luse for his help and encouragement in getting this done.

 

-- 

John Meneghini

johnm@netapp.com

 

 

From: "Chandrashekar, Girish" <Girish.Chandrashekar@netapp.com>
Date: Tuesday, November 14, 2017 at 1:00 PM
To: John Meneghini <John.Meneghini@netapp.com>, "Luse, Paul E" <paul.e.luse@intel.com>
Subject: Re: histogram patches

 

Hi John,

   Changes to rdma.c will not affect much as it comes under #ifdef HISTOGRAM,

spdk/lib/env_dpdk/pci_virtio.c can be ignored as it has empty line as diff

 

Paul has to wait, since I missed to address 14 minor comments from Daniel. I will finish this before weekend along with unit test.

Can I use remote_histogram_changes22 branch to address these comments?

 

Regards

Girish

 

 

 

From: Girish Chandrashekar <Girish.Chandrashekar@netapp.com>
Date: Monday, November 13, 2017 at 10:45 AM
To: "Meneghini, John" <John.Meneghini@netapp.com>, "Luse, Paul E" <paul.e.luse@intel.com>
Subject: Re: histogram patches

 

Thanks John, I will test once patch is ready

 

Regards

Girish

 

From: "Meneghini, John" <John.Meneghini@netapp.com>
Date: Monday, November 13, 2017 at 10:44 AM
To: "Luse, Paul E" <paul.e.luse@intel.com>, Girish Chandrashekar <Girish.Chandrashekar@netapp.com>
Cc: "Meneghini, John" <John.Meneghini@netapp.com>
Subject: Re: histogram patches

 

Sure thing Paul.  Thanks for your help.

 

Girish, I’ll download these patches on Monday and pull them into the VED so you can test them out.  In the meantime, you can see Paul’s updates to the pull request in GerritHub at:

 

https://review.gerrithub.io/#/c/363114/

 

If everything looks good, please feel free to give Paul the go ahead and these patches can be checked into SPDK.

 

I’ve already approved these changes.

 

/John

 

From: "Luse, Paul E" <paul.e.luse@intel.com>
Date: Saturday, November 11, 2017 at 1:55 PM
To: John Meneghini <John.Meneghini@netapp.com>
Subject: histogram patches

 

Hi John,

 

I rebased the patches last week so they’re ready for Girish to take a look at, fix where I may have missed something and address Daniel’s last set of comments.  Two things during the rebase:

 

- in rdma.c there were two ‘finish markers’ that I couldn’t find a good home for in the refactored code.  I think I got one of them right but either Girish or Ben or someone will have to pinpoint where the other marker should go, I just have never looked at any of the NVMeoF stuff before so was essentially guessing

- the rebase picked up some conflicts in spdk/lib/env_dpdk/pci_virtio.c which seemed odd since it wasn’t touced in any of the patches that I could tell so I just took the latest so he might want to double check and make sure there’s not something missing there

 

Other than that it was pretty straightforward

 

Thx

Paul