Thanks for your review.
Paolo Abeni <pabeni(a)redhat.com> 于2020年9月2日周三 上午12:02写道：
On Mon, 2020-08-24 at 19:36 +0800, Geliang Tang wrote:
> - drop anno_list in v7.
> We don't need to add a new list, conn_list is enough for the signal
> address and local subflow.
I think this could be problematic.
An MPTCP socket could refuse or delay the creation of new subflows for
addresses received via ADD_ADDR.
But an MPTCP should send REMOVE_ADDR for accounced addresses, even if
no subflows exists on top of them.
Removing the anno_list we lose this ability.
Yes, we can't cover this case, but the v7 code with anno_list can't cover
it either. Since anno_list only recorded the local announced addresses,
we need also record the received addresses on the remote side.
I'll write a patch to fix this problem later.
I'd like to avoid additional interations, if possible, and eventually
add squash-to fixes if/where needed. Other options more than welcome.
Since my another patchset 'add ADD_ADDR echo flag support' is accepted,
v8 will conflict with it. So here I simply updated the v8 patchset as
you suggested and sent out the v9 version.
very minor note: this does not respect the reverse x-mas tree order.
Otherwise looks good.
Note: I think you can submit this patch and the previous one (4/8)
directly to -net (with an appropriate Fixes tag).
Since patch 5/8 is depended on the patch 'mptcp: add the incoming RM_ADDR
support', which is only on net-next's export branch, we can't directly
submit 4/8 and 5/8 to -net. So here I still keeped them in the v9 patchset.