On Fri, 13 Dec 2019, Matthieu Baerts wrote: > Hello, > > A few hours ago, I recreated the TopGit tree using Paolo's branch. > > Now I just applied all pending patches except the ones adding the > MAINTAINERS file (because it is late and not affecting tests :) ) > > My CI detected that when running the kselftests on the latest "mptcp: > add basic kselftest for mptcp" commit (MPTCPv0), we have an issue. Not > when running them on "mptcp: process MP_CAPABLE data option." > (MPTCPv1) or at the end of the series. > It seems that the issue has been introduced after having applied > patches cleaning the fallback handling. > Paolo is already looking at that in cave mode. > > Please also note that now the CI is testing the kselftests with 3 > different version: > > - on "mptcp: add basic kselftest for mptcp" commit > - on "mptcp: process MP_CAPABLE data option." commit (new) > - at the end of the series ("export" branch) > > > > Here are the items we need to do before this Friday evening (US time): > > - Test patches → *all* > > - Share cover-letter for part 3 → *Christoph* > - Review cover-letters → *all* > > - Remove the fix in KSelftest framework → *Matth* > - Apply the fix in KSelftest framework only for CI → *Matth* > > - Apply patches related to the MAINTAINERS file → *Matth* > - Add our mailing-list in the MAINTAINERS file → *Matth* > > - Share patch(es) fixing kselftests when introduced → *Paolo* > - Review this/these patch(es) → *EU-based people* (and others later) > - Apply these patches → *Matth* > > - Share patches fixing remaining checkpatch issues → *Davide* > - Review these patches → *EU-based people* (and others later) > - Apply these patches → *Matth* > > - Add Mat (part 1 & 2) and Christoph' (part 3) signed-off → *Matth* > > - Share patches like we are going to send → *Matth* > - Review these patches → *all* > > - Send Part 1 → *Mat* > - Send Part 2 → *Mat* > - Send Part 3 → *Christoph* > > Did I miss anything? Anything wrong? > Addition:  - Tag part1/part2/part3 and push to github It's fine if you leave that for me in case there are last-minute tweaks affecting commit hashes.

On 13/12/2019 00:36, Matthieu Baerts wrote: > Here are the items we need to do before this Friday evening (US time): > > - Test patches → *all* - Compilations: [ OK ] - each commit with/without MPTCP, x86_64 - i386 - with/without IPv6 - kselftests, with and without KASAN + PROVE_LOCKING: [ OK ] - on "mptcp: add basic kselftest for mptcp" commit - on "mptcp: process MP_CAPABLE data option." commit (new) - at the end of the series ("export" branch)

> - Share cover-letter for part 3 → *Christoph* Done! Thank you! > - Review cover-letters → *all* I just added 2 new items on the list, please see: https://annuel2.framapad.org/p/mptcp_upstreaming_20191220 [ ] Review commit messages → *all*: [X] Mat: sent some patches modifying the .topmsg [ ] Review patches [ ] Apply patches [ ] Do we need a cover-letter for the cover-letters?: - I mean: a short introduction to explain what we are going to send: - The protocol is what it is and having a minimal set of features already signifies a lot of code. - This minimal set of features includes: the possibility for the userspace to establish and properly terminate MPTCP connections but limited to one subflow while still being able to transfer data in both directions - We decided to split everything in 3 parts to ease the reviews: - Part 1: Prerequisite TCP core changes - Part 2: MPTCP minimal set of features including selftests - Part 3: a switch from MPTCPv0 (RFC 6824) to MPTCPv1 (new RFC 8684 going to obsolete the previous one in the coming days) - The idea would be to apply everything in once (?) - we can also include that in the cover letter of Part 1

Hello, On 13/12/2019 00:36, Matthieu Baerts wrote: > Here are the items we need to do before this Friday evening (US time): > > - Test patches → *all* - Compilations: [ OK ] - each commit with/without MPTCP, x86_64 - i386 - with/without IPv6 - kselftests, with and without KASAN + PROVE_LOCKING: [ OK ] - on "mptcp: add basic kselftest for mptcp" commit - on "mptcp: process MP_CAPABLE data option." commit (new) - at the end of the series ("export" branch) > - Share cover-letter for part 3 → *Christoph* Done! Thank you! > - Review cover-letters → *all* I just added 2 new items on the list, please see: https://annuel2.framapad.org/p/mptcp_upstreaming_20191220 [ ] Review commit messages → *all*: [X] Mat: sent some patches modifying the .topmsg [ ] Review patches [ ] Apply patches [ ] Do we need a cover-letter for the cover-letters?: - I mean: a short introduction to explain what we are going to send: - The protocol is what it is and having a minimal set of features already signifies a lot of code. - This minimal set of features includes: the possibility for the userspace to establish and properly terminate MPTCP connections but limited to one subflow while still being able to transfer data in both directions - We decided to split everything in 3 parts to ease the reviews: - Part 1: Prerequisite TCP core changes - Part 2: MPTCP minimal set of features including selftests - Part 3: a switch from MPTCPv0 (RFC 6824) to MPTCPv1 (new RFC 8684 going to obsolete the previous one in the coming days) - The idea would be to apply everything in once (?) - we can also include that in the cover letter of Part 1 What do you think?

@Davide: packtdrill here would save our day to test!!!