Mat noted the current code access ssk data outside the relevant socket lock. Fix that moving the update in such scope Fixes: 28d2e02041c9 ("mptcp: implement and use MPTCP-level retransmission") Signed-off-by: Paolo Abeni <pabeni(a)redhat.com&gt; --- I'm ok with squashing this into the fixed commit --- net/mptcp/protocol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 439d6744c8e2..a26b74a706c0 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -830,11 +830,11 @@ static void mptcp_retransmit(struct work_struct *work) dfrag->offset = orig_offset; dfrag->data_len = orig_len; + mptcp_set_timeout(sk, ssk); release_sock(ssk); sock_put(ssk); reset_unlock: - mptcp_set_timeout(sk, ssk); if (!mptcp_timer_pending(sk)) mptcp_reset_timer(sk); -- 2.21.0