Paolo Abeni <pabeni(a)redhat.com> wrote:
+ /* when assiging the token to the msk, we need to held
+ * an additional reference, will be released at msk token
+ * destruction time
Unrelated to your patch, but I think this is wrong.
We should have implicit reference for the token.
Taking a reference makes no sense because the token lifetime is limited by
the mptcp socket -- if the mptcp socket is closing, we remove the token too.
token_release() function makes no sense to me -- afaics all callers
have a pointer to the msk they want to put the reference for.
I'll have a look into cleaning that up after respinning a squashable
version of the token refactoring.