February 2019 - mptcp

MPTCP architecture proposal - RFCv7 changes pushed

by Mat Martineau

Hello - I've pushed a new revision of the MPTCP kernel architecture proposal: https://review.gerrithub.io/q/project:multipath-tcp%252Fmptcp_net-next+st... https://git.kernel.org/pub/scm/linux/kernel/git/martineau/linux.git/log/?... Changes: * Added Florian's commits for kselftest/etc * Fixed read length bug that Florian noted * Fixed compilation without CONFIG_IPV6 * Fixed DSS re-parsing warning when reading partial skb Thanks, -- Mat Martineau Intel

1 year, 8 months

1
1
0 / 0

[Weekly meetings] MoM - 28th of February 2019

by Matthieu Baerts

Hello, We just had our 41th meeting with Mat, Peter and Ossama (Intel OTC), Christoph (Apple), Florian (Red Hat) and myself (Tessares). Thanks again for this new good meeting! Here are the minutes of the meeting: new MPTCP design: - New RFCv7: * Added Florian's commits for kselftest/etc * Fixed read length bug that Florian noted * Fixed compilation without CONFIG_IPV6 * Fixed DSS re-parsing warning when reading partial skb * ULP changes are not part of this patch-set (yet) * note: what is on Gerrit is slightly different (sync with latest net-next) - Reviews are welcomed! - https://review.gerrithub.io/q/project:multipath-tcp%252Fmptcp_net-next+br... - git fetch "https://github.com/multipath-tcp/mptcp_net-next" refs/changes/74/446474/1 && git checkout FETCH_HEAD - https://github.com/multipath-tcp/mptcp_net-next/commit/674546902f011e4b6e... - https://git.kernel.org/pub/scm/linux/kernel/git/martineau/linux.git/log/?... Commits for upstream: - do we need to add Reviewed-by/Acked-by/Signed-off-by? - not for the moment - in topic: only remove ChangeId ref - in cover letter: we will see later how to mention that this patch-set is supported by different people from different companies. - now a few commits in "export" branch - https://github.com/multipath-tcp/mptcp_net-next/commits/export - new 'for-review' branch: - https://github.com/multipath-tcp/mptcp_net-next/commits/for-review - if you use TopGit internally to manage your different commits you want to integrate on top of other MPTCP changes (on top of t/upstream or export), you can now base your tree on top of 'for-review' branch (you can also use it as target for 'git-review' or keep 't/upstream', that will be the same from a Gerrit point of view) - this new branch 'for-review' is like 't/upstream' (top of the tree) but without TopGit files: Gerrit will see when changes are integrated in the tree (not like 'export') because Change-Id are preserved and mark changes as merged automatically when it is in the tree. Also with this new branch, you don't have any .top* files on this branch. - in other words: - use this branch as base and target: git checkout -b <new_feature> for-review (...) git commit -s git review for-review - note for Mat: for your existing patch-set: continue to use 't/upstream' as target not to create new changes. That's OK for Gerrit. But you can rebase your patch-set on top of 'for-review' - branches in our repo: → https://github.com/multipath-tcp/mptcp_net-next/wiki/Gerrit#different-bra... - master → like mptcp_trunk but with less features. (still sync?) - net-next → sync of Dave's net-next - t/upstream → top of the tree containing our changes on top of net-next - t/* → other topic: correspond to one commit we want to send upstream (.topdeps: parent topic(s) ; .topmsg: commit message) - export → an export of the tree on top of net-next: what we should send upstream - for-review → same as t/upstream but without TopGit files: can be use as a base and target for your reviews Syzkaller for MPTCP running now on v0.94: - https://github.com/google/syzkaller - Running on Christoph side - really easy to setup - would be nice to have it for MPTCP net-next - good to restrict to net syscall - for net-next, we just need to ask to create MPTCP socket - MPTCP in syscall is already there! - new patches will come! Papers related to MPTCP: - Fixed-Mobile Convergence in the 5G era: From Hybrid Access to Converged Core → https://nms.kcl.ac.uk/toktam.mahmoodi/files/FMC-Network.pdf Netdev 0x13: - Florian will be there (and talk about Skb Meta Data Extensions https://www.netdevconf.org/0x13/session.html?skb-meta-data-extensions ) - Matthieu will be there (with 2 other colleagues) - Peter will check if he can go - Could be nice to meet each others at LPC 2019 (September 9-11, Lisbon, Portugal) multipath-tcp: - mptcp_v0.94 branch has been recently updated (sync with upstream) Next meeting: - We propose to have the next one on Thursday, the 7th of March. - Usual time: 17:00 UTC (9am PST, 6pm CET) - Still open to everyone! - https://annuel2.framapad.org/p/mptcp_upstreaming_20190307 Feel free to comment on these points and propose new ones for the next meeting! Talk to you next week, Matthieu -- Matthieu Baerts | R&D Engineer matthieu.baerts(a)tessares.net Tessares SA | Hybrid Access Solutions www.tessares.net 1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

1 year, 8 months

1
0
0 / 0

Change in ...mptcp_net-next[t/upstream]: mptcp: add basic kselftest program

by Mat Martineau (GerritHub)

Mat Martineau has uploaded this change for review. ( https://review.gerrithub.io/c/multipath-tcp/mptcp_net-next/+/446474 Change subject: mptcp: add basic kselftest program ...................................................................... mptcp: add basic kselftest program create mptcp connection between two processes, xmit data back and forth. Data is read from stdin and written (after traversing mtcp connection twice) to stdout. Wrapper script tests that data has passed un-altered. Will run automatically on "make kselftest". Signed-off-by: Florian Westphal <fw(a)strlen.de> Change-Id: I31f585fceef36b26bbd937140e8f0b2c51d222f0 --- M tools/testing/selftests/Makefile A tools/testing/selftests/net/mptcp/Makefile A tools/testing/selftests/net/mptcp/config A tools/testing/selftests/net/mptcp/mptcp_connect.c A tools/testing/selftests/net/mptcp/mptcp_connect.sh 5 files changed, 445 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/multipath-tcp/mptcp_net-next refs/changes/74/446474/1 -- To view, visit https://review.gerrithub.io/c/multipath-tcp/mptcp_net-next/+/446474 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: multipath-tcp/mptcp_net-next Gerrit-Branch: t/upstream Gerrit-Change-Id: I31f585fceef36b26bbd937140e8f0b2c51d222f0 Gerrit-Change-Number: 446474 Gerrit-PatchSet: 1 Gerrit-Owner: Mat Martineau <mathew.j.martineau(a)linux.intel.com> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 / 0

Change in ...mptcp_net-next[t/upstream]: mptcp: add and use mptcp_subflow_hold

by Mat Martineau (GerritHub)

Mat Martineau has uploaded this change for review. ( https://review.gerrithub.io/c/multipath-tcp/mptcp_net-next/+/446473 Change subject: mptcp: add and use mptcp_subflow_hold ...................................................................... mptcp: add and use mptcp_subflow_hold subflow sockets already have lifetime managed by RCU, so we can switch to atomic_inc_not_zero and skip/pretend we did not find such socket in the mptcp subflow list. This is required to get rid of synchronize_rcu() from mptcp_close(). Signed-off-by: Florian Westphal <fw(a)strlen.de> Change-Id: I568fb486b0003cf2a05933f36413d3270013050a --- M net/mptcp/protocol.c 1 file changed, 67 insertions(+), 38 deletions(-) git pull ssh://review.gerrithub.io:29418/multipath-tcp/mptcp_net-next refs/changes/73/446473/1 -- To view, visit https://review.gerrithub.io/c/multipath-tcp/mptcp_net-next/+/446473 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: multipath-tcp/mptcp_net-next Gerrit-Branch: t/upstream Gerrit-Change-Id: I568fb486b0003cf2a05933f36413d3270013050a Gerrit-Change-Number: 446473 Gerrit-PatchSet: 1 Gerrit-Owner: Mat Martineau <mathew.j.martineau(a)linux.intel.com> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 / 0

Change in ...mptcp_net-next[t/upstream]: mptcp: add mptcp_poll

by Mat Martineau (GerritHub)

Mat Martineau has uploaded this change for review. ( https://review.gerrithub.io/c/multipath-tcp/mptcp_net-next/+/446472 Change subject: mptcp: add mptcp_poll ...................................................................... mptcp: add mptcp_poll Can't use tcp_poll directly: BUG: KASAN: slab-out-of-bounds in tcp_poll+0x17f/0x540 Read of size 4 at addr ffff88806ac5e50c by task mptcp_connect/2085 Call Trace: tcp_poll+0x17f/0x540 sock_poll+0x152/0x180 Signed-off-by: Florian Westphal <fw(a)strlen.de> Change-Id: Ibf354be7630ecd44d82ff44a9b692e4862120229 --- M net/mptcp/protocol.c 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/multipath-tcp/mptcp_net-next refs/changes/72/446472/1 -- To view, visit https://review.gerrithub.io/c/multipath-tcp/mptcp_net-next/+/446472 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: multipath-tcp/mptcp_net-next Gerrit-Branch: t/upstream Gerrit-Change-Id: Ibf354be7630ecd44d82ff44a9b692e4862120229 Gerrit-Change-Number: 446472 Gerrit-PatchSet: 1 Gerrit-Owner: Mat Martineau <mathew.j.martineau(a)linux.intel.com> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 / 0

Change in ...mptcp_net-next[scripts]: ci:upd-tg: update 'for-review' branch

by Matthieu Baerts (GerritHub)

Matthieu Baerts has uploaded this change for review. ( https://review.gerrithub.io/c/multipath-tcp/mptcp_net-next/+/446449 Change subject: ci:upd-tg: update 'for-review' branch ...................................................................... ci:upd-tg: update 'for-review' branch If you use TopGit internally to manage your different commits you want to integrate on top of other MPTCP changes (on top of t/upstream or export), you can now base your tree on top of 'for-review' branch (you can also use it as target for 'git-review' or keep 't/upstream', that will be the same from a Gerrit point of view): this new branch 'for-review' is like 't/upstream' (top of the tree) but without TopGit files: Gerrit will see when changes are integrated in the tree (not like 'export') because Change-Id are preserved and mark changes as merged automatically when it is in the tree. Also with this new branch, you don't have any .top* files on this branch. In other words, use this branch as base and target for new changes. Signed-off-by: Matthieu Baerts <matthieu.baerts(a)tessares.net> Change-Id: Ieaedba4c703e6c374015afef876ad53d7cb561d9 --- M ci/update-tg-tree.sh 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/multipath-tcp/mptcp_net-next refs/changes/49/446449/1 -- To view, visit https://review.gerrithub.io/c/multipath-tcp/mptcp_net-next/+/446449 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: multipath-tcp/mptcp_net-next Gerrit-Branch: scripts Gerrit-Change-Id: Ieaedba4c703e6c374015afef876ad53d7cb561d9 Gerrit-Change-Number: 446449 Gerrit-PatchSet: 1 Gerrit-Owner: Matthieu Baerts <matthieu.baerts(a)tessares.net> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 / 0

Weekly meeting - 28 February 2019 17:00 UTC (9am PST, 6pm CET)

by Matthieu Baerts

Hello everybody! Our public MPTCP upstreaming weekly web conference is scheduled for tomorrow. The list of topics is available here: https://annuel2.framapad.org/p/mptcp_upstreaming_20190228 Feel free to add/modify topics! Anybody can join the meeting using Google Meet website/app/phone: https://meet.google.com/edk-rkrk-vaj Speak to you tomorrow! Matthieu -- Matthieu Baerts | R&D Engineer matthieu.baerts(a)tessares.net Tessares SA | Hybrid Access Solutions www.tessares.net 1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

1 year, 9 months

1
0
0 / 0

Change in ...mptcp_net-next[scripts]: ci:upd-tg: allow to force a sync

by Matthieu Baerts (GerritHub)

Matthieu Baerts has uploaded this change for review. ( https://review.gerrithub.io/c/multipath-tcp/mptcp_net-next/+/446296 Change subject: ci:upd-tg: allow to force a sync ...................................................................... ci:upd-tg: allow to force a sync Only for debugging purpose, not to stop if there is no net-next update. Signed-off-by: Matthieu Baerts <matthieu.baerts(a)tessares.net> Change-Id: I2d881336e7abaab068871a990491740c69dc828a --- M ci/Dockerfile.update-tg-tree.sh M ci/update-tg-tree.sh 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/multipath-tcp/mptcp_net-next refs/changes/96/446296/1 -- To view, visit https://review.gerrithub.io/c/multipath-tcp/mptcp_net-next/+/446296 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: multipath-tcp/mptcp_net-next Gerrit-Branch: scripts Gerrit-Change-Id: I2d881336e7abaab068871a990491740c69dc828a Gerrit-Change-Number: 446296 Gerrit-PatchSet: 1 Gerrit-Owner: Matthieu Baerts <matthieu.baerts(a)tessares.net> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 / 0

Change in ...mptcp_net-next[scripts]: ci:upd-tg: update kconfig with scripts/config

by Matthieu Baerts (GerritHub)

Matthieu Baerts has uploaded this change for review. ( https://review.gerrithub.io/c/multipath-tcp/mptcp_net-next/+/446295 Change subject: ci:upd-tg: update kconfig with scripts/config ...................................................................... ci:upd-tg: update kconfig with scripts/config Cleaner than appending the .config file. Also added a note why 'make olddefconfig' is not used. Signed-off-by: Matthieu Baerts <matthieu.baerts(a)tessares.net> Change-Id: I392af31cb71642007da087d83552a97274fc25d6 --- M ci/update-tg-tree.sh 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/multipath-tcp/mptcp_net-next refs/changes/95/446295/1 -- To view, visit https://review.gerrithub.io/c/multipath-tcp/mptcp_net-next/+/446295 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: multipath-tcp/mptcp_net-next Gerrit-Branch: scripts Gerrit-Change-Id: I392af31cb71642007da087d83552a97274fc25d6 Gerrit-Change-Number: 446295 Gerrit-PatchSet: 1 Gerrit-Owner: Matthieu Baerts <matthieu.baerts(a)tessares.net> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 / 0

Change in ...mptcp_net-next[scripts]: ci:upd-tg: for TG to use refs/top-bases

by Matthieu Baerts (GerritHub)

Matthieu Baerts has uploaded this change for review. ( https://review.gerrithub.io/c/multipath-tcp/mptcp_net-next/+/446294 Change subject: ci:upd-tg: for TG to use refs/top-bases ...................................................................... ci:upd-tg: for TG to use refs/top-bases From: https://github.com/mackyle/topgit#tg-migrate-bases > Beginning with TopGit release 0.19.4, TopGit has the ability to store > the top-bases refs in either the old ref/top-bases/... location or the > new refs/heads/{top-bases}/... location. Starting with TopGit release > 0.20.0, the default is the new location. We force the 'old' location because Gerrit is configured for a use with these refs and in the script, we also use refs/top-bases. Signed-off-by: Matthieu Baerts <matthieu.baerts(a)tessares.net> Suggested-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com> Change-Id: I6bb61ee898228204eab8a1bc2072b58ba065d46c --- M ci/update-tg-tree.sh 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/multipath-tcp/mptcp_net-next refs/changes/94/446294/1 -- To view, visit https://review.gerrithub.io/c/multipath-tcp/mptcp_net-next/+/446294 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: multipath-tcp/mptcp_net-next Gerrit-Branch: scripts Gerrit-Change-Id: I6bb61ee898228204eab8a1bc2072b58ba065d46c Gerrit-Change-Number: 446294 Gerrit-PatchSet: 1 Gerrit-Owner: Matthieu Baerts <matthieu.baerts(a)tessares.net> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 / 0

2020

2019

2018

2017

mptcp February 2019