On Wed 16-09-20 11:22:05, Mike Snitzer wrote:
On Wed, Sep 16 2020 at 11:14am -0400,
Jan Kara <jack(a)suse.cz> wrote:
> DM was calling generic_fsdax_supported() to determine whether a device
> referenced in the DM table supports DAX. However this is a helper for
"leaf" device drivers so that
> they don't have to duplicate common generic checks. High level code
> should call dax_supported() helper which that calls into appropriate
> helper for the particular device. This problem manifested itself as
> kernel messages:
> dm-3: error: dax access failed (-95)
> when lvm2-testsuite run in cases where a DM device was stacked on top of
> another DM device.
> Fixes: 7bf7eac8d648 ("dax: Arrange for dax_supported check to span multiple
> Tested-by: Adrian Huang <ahuang12(a)lenovo.com>
> Signed-off-by: Jan Kara <jack(a)suse.cz>
Acked-by: Mike Snitzer <snitzer(a)redhat.com>
This fix should Cc stable@ right?
Yes, it should go to stable.
> drivers/dax/super.c | 4 ++++
> drivers/md/dm-table.c | 3 +--
> include/linux/dax.h | 11 +++++++++--
> 3 files changed, 14 insertions(+), 4 deletions(-)
> This patch should go in together with Adrian's
Sure, but there really isn't a dependency right?
Yes, it isn't a context or strict functional dependency. But without this
patch Adrian's patch just trades one set of warnings for another set of
Jan Kara <jack(a)suse.com>
SUSE Labs, CR