5:14 p.m.
Fix for the cros-compilation with Chromium OS’s toolchain that
uses GCC 4.9
---
ell/genl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ell/genl.c b/ell/genl.c
index cff3a9a..d9cfddb 100644
--- a/ell/genl.c
+++ b/ell/genl.c
@@ -498,7 +498,7 @@ static bool received_data(struct l_io *io, void *user_data)
group = pktinfo.group;
}
- for (nlmsg = iov.iov_base; NLMSG_OK(nlmsg, bytes_read);
+ for (nlmsg = iov.iov_base; NLMSG_OK(nlmsg, (uint32_t) bytes_read);
nlmsg = NLMSG_NEXT(nlmsg, bytes_read)) {
if (group > 0)
process_multicast(genl, group, nlmsg);
--
2.9.4
5:26 p.m.
Hi Tim,
On Fri, Jul 14, 2017 at 10:14 AM, Tim Kourt <tim.a.kourt(a)linux.intel.com>
wrote:
- for (nlmsg = iov.iov_base; NLMSG_OK(nlmsg, bytes_read);
+ for (nlmsg = iov.iov_base; NLMSG_OK(nlmsg, (uint32_t) bytes_read);
NLMSG_OK() expects an int for the second argument. Assuming truncation
isn't an issue here, wouldn't it be better to cast to an int instead?
-Ossama
8:57 p.m.
Hi Ossama,
NLMSG_OK() expects an int for the second argument. Assuming
truncation isn't an issue here, wouldn't it be better to cast to an int instead?
The uint32_t was used to keep the consistency with the other usages of NLMSG_OK() within
ELL and thereafter IWD. Maybe it is time to fix all of them.
Best regards,
Tim
8:09 p.m.
Hi Tim,
On Fri, Jul 14, 2017 at 1:57 PM, Kourt, Tim A <tim.a.kourt(a)intel.com> wrote:
> NLMSG_OK() expects an int for the second argument. Assuming truncation
isn't an issue here, wouldn't it be better to cast to an int instead?
The uint32_t was used to keep the consistency with the other usages of
NLMSG_OK() within ELL and thereafter IWD. Maybe it is time to fix all of
them.
I did some digging into the NLMSG_OK() macro and found several patches and
discussions related to this very same issue. It looks like everyone does
indeed cast to an unsigned integer, even though the documentation states
that the type is int. Patches to "fix" the issue with the macro have all
been rejected, too. Consistency wins. :)
-Ossama
1858
days inactive
1861
days old
3 comments
3 participants
participants (3)
-
Kourt, Tim A -
Othman, Ossama -
Tim Kourt