-----Original Message----- From: Devel [mailto:[email protected]] On Behalf Of Neel Natu Sent: Monday, August 11, 2014 2:12 PM To: devel(a)acpica.org Subject: [Devel] Patch to override "Creator ID" and "Creator Revision" Hi, The following patch allows the "Creator ID" and "Creator Revision" to be overridden at compile time. At the moment the "Creator Revision" is a stand-in for the compiler version which implies that the tables change every time the compiler version changes. This patch decouples "Creator Revision" from the compiler version. It would be great if this could be committed. best Neel diff --git a/source/compiler/asldefine.h b/source/compiler/asldefine.h index b05bd7f..6a15bf1 100644 --- a/source/compiler/asldefine.h +++ b/source/compiler/asldefine.h @@ -125,7 +125,9 @@ #define ASL_COMPILER_NAME "ASL Optimizing Compiler" #define AML_DISASSEMBLER_NAME "AML Disassembler" #define ASL_INVOCATION_NAME "iasl" +#ifndef ASL_CREATOR_ID #define ASL_CREATOR_ID "INTL" +#endif #define ASL_COMPLIANCE "Supports ACPI Specification Revision 5.1" diff --git a/source/include/acpixf.h b/source/include/acpixf.h index cafc37b..005325c 100644 --- a/source/include/acpixf.h +++ b/source/include/acpixf.h @@ -118,7 +118,9 @@ /* Current ACPICA subsystem version in YYYYMMDD format */ +#ifndef ACPI_CA_VERSION #define ACPI_CA_VERSION 0x20140724 +#endif #include "acconfig.h" #include "actypes.h" _______________________________________________ Devel mailing list Devel(a)acpica.org https://lists.acpica.org/mailman/listinfo/devel

CreatorID is meant to identify the compiler. The OemID, etc. are meant to identify the manufacturer of the table.

So, why would you want to override the compiler revision? A different version of the compiler can certainly generate different table contents, and this helps us identify the compiler used to build the table.

> -----Original Message----- > From: Devel [mailto:[email protected]] On Behalf Of Moore, Robert > Sent: Monday, August 11, 2014 2:37 PM > To: Neel Natu; devel(a)acpica.org > Subject: Re: [Devel] Patch to override "Creator ID" and "Creator Revision" > > I doubt we would allow the creator ID to be overridden. > > > > > -----Original Message----- > > From: Devel [mailto:[email protected]] On Behalf Of Neel Natu > > Sent: Monday, August 11, 2014 2:12 PM > > To: devel(a)acpica.org > > Subject: [Devel] Patch to override "Creator ID" and "Creator Revision" > > > > Hi, > > > > The following patch allows the "Creator ID" and "Creator Revision" to > > be overridden at compile time. > > > > At the moment the "Creator Revision" is a stand-in for the compiler > > version which implies that the tables change every time the compiler > > version changes. This patch decouples "Creator Revision" from the > > compiler version. > > > > It would be great if this could be committed. > > > > best > > Neel > > > > diff --git a/source/compiler/asldefine.h b/source/compiler/asldefine.h > > index b05bd7f..6a15bf1 100644 > > --- a/source/compiler/asldefine.h > > +++ b/source/compiler/asldefine.h > > @@ -125,7 +125,9 @@ > > #define ASL_COMPILER_NAME "ASL Optimizing Compiler" > > #define AML_DISASSEMBLER_NAME "AML Disassembler" > > #define ASL_INVOCATION_NAME "iasl" > > +#ifndef ASL_CREATOR_ID > > #define ASL_CREATOR_ID "INTL" > > +#endif > > > > #define ASL_COMPLIANCE "Supports ACPI Specification > Revision > > 5.1" > > > > diff --git a/source/include/acpixf.h b/source/include/acpixf.h index > > cafc37b..005325c 100644 > > --- a/source/include/acpixf.h > > +++ b/source/include/acpixf.h > > @@ -118,7 +118,9 @@ > > > > /* Current ACPICA subsystem version in YYYYMMDD format */ > > > > +#ifndef ACPI_CA_VERSION > > #define ACPI_CA_VERSION 0x20140724 > > +#endif > > > > #include "acconfig.h" > > #include "actypes.h" > > _______________________________________________ > > Devel mailing list > > Devel(a)acpica.org > > https://lists.acpica.org/mailman/listinfo/devel > _______________________________________________ > Devel mailing list > Devel(a)acpica.org > https://lists.acpica.org/mailman/listinfo/devel

Sometimes the output does in fact change across compiler versions. Really, how difficult is it to just ignore this field, or even the entire ACPI table header? We even have a utility to do it, called acpibin.

Bob > -----Original Message----- > From: Neel Natu [mailto:[email protected]] > Sent: Monday, August 11, 2014 3:02 PM > To: Moore, Robert > Cc: devel(a)acpica.org > Subject: Re: [Devel] Patch to override "Creator ID" and "Creator Revision" > > Hi Robert, > > On Mon, Aug 11, 2014 at 2:40 PM, Moore, Robert <robert.moore(a)intel.com&gt; > wrote: > > CreatorID is meant to identify the compiler. The OemID, etc. are meant > to identify the manufacturer of the table. > > > > Indeed. I got a bit carried away :-) > > > So, why would you want to override the compiler revision? A different > version of the compiler can certainly generate different table contents, > and this helps us identify the compiler used to build the table. > > > > I use this to compare the generated tables on different systems. > > If the output changes because different compilers do output different > table contents then that's one thing. > > However, if the only difference between the generated tables is due to the > compiler revision then I would like a way to control that. I expect this > to be the common case but perhaps I am mistaken? > > best > Neel > > > > > > >> -----Original Message----- > >> From: Devel [mailto:[email protected]] On Behalf Of Moore, > >> Robert > >> Sent: Monday, August 11, 2014 2:37 PM > >> To: Neel Natu; devel(a)acpica.org > >> Subject: Re: [Devel] Patch to override "Creator ID" and "Creator > Revision" > >> > >> I doubt we would allow the creator ID to be overridden. > >> > >> > >> > >> > -----Original Message----- > >> > From: Devel [mailto:[email protected]] On Behalf Of Neel > >> > Natu > >> > Sent: Monday, August 11, 2014 2:12 PM > >> > To: devel(a)acpica.org > >> > Subject: [Devel] Patch to override "Creator ID" and "Creator > Revision" > >> > > >> > Hi, > >> > > >> > The following patch allows the "Creator ID" and "Creator Revision" > >> > to be overridden at compile time. > >> > > >> > At the moment the "Creator Revision" is a stand-in for the compiler > >> > version which implies that the tables change every time the > >> > compiler version changes. This patch decouples "Creator Revision" > >> > from the compiler version. > >> > > >> > It would be great if this could be committed. > >> > > >> > best > >> > Neel > >> > > >> > diff --git a/source/compiler/asldefine.h > >> > b/source/compiler/asldefine.h index b05bd7f..6a15bf1 100644 > >> > --- a/source/compiler/asldefine.h > >> > +++ b/source/compiler/asldefine.h > >> > @@ -125,7 +125,9 @@ > >> > #define ASL_COMPILER_NAME "ASL Optimizing Compiler" > >> > #define AML_DISASSEMBLER_NAME "AML Disassembler" > >> > #define ASL_INVOCATION_NAME "iasl" > >> > +#ifndef ASL_CREATOR_ID > >> > #define ASL_CREATOR_ID "INTL" > >> > +#endif > >> > > >> > #define ASL_COMPLIANCE "Supports ACPI Specification > >> Revision > >> > 5.1" > >> > > >> > diff --git a/source/include/acpixf.h b/source/include/acpixf.h > >> > index cafc37b..005325c 100644 > >> > --- a/source/include/acpixf.h > >> > +++ b/source/include/acpixf.h > >> > @@ -118,7 +118,9 @@ > >> > > >> > /* Current ACPICA subsystem version in YYYYMMDD format */ > >> > > >> > +#ifndef ACPI_CA_VERSION > >> > #define ACPI_CA_VERSION 0x20140724 > >> > +#endif > >> > > >> > #include "acconfig.h" > >> > #include "actypes.h" > >> > _______________________________________________ > >> > Devel mailing list > >> > Devel(a)acpica.org > >> > https://lists.acpica.org/mailman/listinfo/devel > >> _______________________________________________ > >> Devel mailing list > >> Devel(a)acpica.org > >> https://lists.acpica.org/mailman/listinfo/devel